Custom LoggerText implementation not handling objects

hey folks,
I had to write up a custom logger implementation because I needed to store the logs in a file and rotate them as well. I have extended

LoggerText

LoggerText

and have implemented the methods as well and while its working its skipping a lot of debug messages that we get with the inbuilt logger as well as not being able to handle objects being passed to it. I have looked at the source code for it and have stuck to it as much as I could.

I would really appreciate it if someone could point out whats wrong with it.

code: https://pastebin.com/tpGxyM0P

actual output: https://pastebin.com/ABtC8QSa

Pastebin

import { LoggerText, LogLevel } from 'crawlee';import * as winston ...

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

Pastebin

{"level":"debug","message":"No 'persistStateKeyValueStoreId' option...

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

verbal-limeOP•12/4/23, 7:33 PM

on further debugging, it looks like in the log method, all of the data being sent is treated as exception

verbal-limeOP•12/4/23, 7:36 PM

ok I fixed the debug stuff by flipping the order of function variables and making it like its there in the func

verbal-limeOP•12/4/23, 7:36 PM

but the json is adding everywhere which I know is to skip double quotes but its not like that in the crawlee implementation, is there something I can do to fix it?

verbal-limeOP•12/4/23, 7:38 PM

also I am calling just like in but its not parsing the exception at all and instead has undefined

verbal-limeOP•12/4/23, 7:39 PM

and I am passing an exception along like this

verbal-limeOP•12/7/23, 11:02 PM

Leaving this for others but this is how I fixed it https://pastebin.com/3awiV7ce

Pastebin

import { LoggerText, LogLevel } from 'crawlee';import * as winston ...

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

verbal-limeOP•12/7/23, 11:05 PM

only issue I can find with crawlee's implementation is, I had to break out winston's logger in a separate function because crawlee's log would keep overriding my settings if I imported a different file which was using a crawlee

log

log

too, Not sure if its supposed to be a bug or anything

verbal-limeOP•12/7/23, 11:05 PM

as for double encoding, that was winston's json formatter shenanigans, we are already encoding our json into strings inside and winston was further encoding it as per my setup

Lukas Krivka•12/19/23, 11:12 AM

Thanks, I will pass it to the team to make example

verbal-limeOP•12/19/23, 3:25 PM

yeah, I fixed it here: RequestRouter not using the `log` instance passed in its respective Playwright crawler , just leaving it for others